Skip to content

disk arbitration fix - #35

Closed
mihaiplesa wants to merge 3 commits into
mainfrom
mplesa-disk-arbitration-fix
Closed

mihaiplesa wants to merge 3 commits into
mainfrom
mplesa-disk-arbitration-fix

Conversation

@mihaiplesa

Copy link
Copy Markdown

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Automatic detachment risks active workloads, while stale volume metadata can abort takeover and deletion.

4 open issues
What changed in this PR

Improves macOS volume mounting resilience against Disk Arbitration races and changes attached-volume handling.

Changes:

  • Adds mount retries, command timeouts, and nobrowse.
  • Automatically detaches volumes before reassignment or deletion.
  • Updates the documented sudoers mount command.
File Description
vol Adds resilient mounting and automatic detach handling.
README.md Aligns sudoers instructions with nobrowse mounting.

Review effort: Balanced

Comment thread vol Resolved
Comment thread vol Resolved
Comment thread vol Resolved
Comment thread vol Resolved

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The changes are narrowly scoped, and no blocking issues were identified.

1 open issue
3 resolved since last review

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Disk Arbitration race handling and forced-unmount retries need macOS-specific validation before approval.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@mihaiplesa mihaiplesa closed this Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants